This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 11 Feb 2015 21:57:52 +0000
- Subject: Re: [PATCH] powerpc: Fix inline feraiseexcept, feclearexcept macros
- Authentication-results: sourceware.org; auth=none
- References: <54C2C558 dot 2050304 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1501240219420 dot 15542 at digraph dot polyomino dot org dot uk> <54C6449B dot 60609 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1501261804490 dot 28603 at digraph dot polyomino dot org dot uk> <54C7DC43 dot 7040500 at linux dot vnet dot ibm dot com> <54D8B4F9 dot 1040802 at linux dot vnet dot ibm dot com>
On Mon, 9 Feb 2015, Adhemerval Zanella wrote:
> Ping (with NEWS adjusted to 2.22).
>
> > Indeed, I have dropped the conditionals (I used test-fenv.c as base, but I think
> > in this context they are not really required).
> >
> > Tested on powerpc64 with fix for BZ#17885 applied.
> >
> > --
> >
> > [BZ #17776]
> > * sysdeps/powerpc/bits/fenvinline.h (feraiseexcept): Convert input to
> > integer before bitwise and assembly operations.
> > (feclearexcept): Likewise.
> > * math/test-fenvinline.c: New file.
> > * math/Makefile: Add test-fenvinline test.
OK, though I think we could do for test coverage for the other functions
taking an integer argument (fetestexcept fesetround feenableexcept
fedisableexcept), to protect against this type of bug appearing for any
of them in future.
--
Joseph S. Myers
joseph@codesourcery.com