This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/sunrpc] Exclude rpcent functions and NSS backends for rpc, key when excluding sunrpc.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>, "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 20 Jan 2015 19:55:18 -0500
- Subject: Re: [PATCH roland/sunrpc] Exclude rpcent functions and NSS backends for rpc, key when excluding sunrpc.
- Authentication-results: sourceware.org; auth=none
- References: <20150116234650 dot 3CDF42C39DB at topped-with-meat dot com>
On 01/16/2015 06:46 PM, Roland McGrath wrote:
> The rpcent functions (from <rpc/netdb.h>) are useless in a C library that
> does not include sunrpc support. The getpublickey function was already
> excluded, but its NSS backends were not.
>
> This change just moves around and conditionalizes the code so that those
> are left out when sunrpc is also left out entirely. It has no effect on
> existing configurations, which still build in sunrpc. A future follow-on
> change that should be made eventually is to make the rpcent functions
> unlinkable like the rest of sunrpc, when compiling a compat configuration
> without --enable-obsolete-rpc.
>
> Tested with 'make check-abi' on i686-linux-gnu and x86_64-linux-gnu.
>
> If nobody objects, I'll commit this on Tuesday.
Please do not commit this. We are effectively frozen and only bug fixes
should go into the branch. Definitely not something like this patch.
Please do ask for reviewers though and commit to 2.22 when it opens.
Cheers,
Carlos.