This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Steve Ellcey <sellcey at imgtec dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 22 Dec 2014 18:02:25 +0000
- Subject: Re: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6
- Authentication-results: sourceware.org; auth=none
- References: <2923c970-026c-4e00-be7a-0650e82421b5 at BAMAIL02 dot ba dot imgtec dot org>
On Fri, 19 Dec 2014, Steve Ellcey wrote:
> @@ -188,9 +205,9 @@ LEAF(MEMSET_NAME)
>
> .set nomips16
> .set noreorder
> -/* If the size is less than 2*NSIZE (8 or 16), go to L(lastb). Regardless of
> +/* If the size is less than 4*NSIZE (16 or 32), go to L(lastb). Regardless of
> size, copy dst pointer to v0 for the return value. */
> - slti t2,a2,(2 * NSIZE)
> + slti t2,a2,(4 * NSIZE)
> bne t2,zero,L(lastb)
> move v0,a0
>
This doesn't appear to have anything obvious to do with r6. Please submit
it separately from the r6 changes, with its own rationale (or if it is in
fact needed as part of the r6 changes, please explain further).
In general, r6 changes should not result in any changes to the code in
glibc built for non-r6 - if the best way to support r6 also involves
changes to code for non-r6 (e.g. if some cleanup or optimization naturally
results in r6 support because the non-r6-compatible code was bad in some
way and r6-compatible code is better for all versions, or if code
compatible with both r6 and pre-r6 can be just as good on all versions as
the existing non-r6-compatible code) then it's best to submit those
changes separately.
--
Joseph S. Myers
joseph@codesourcery.com