This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch, MIPS] Fix warning in sysdeps/mips/dl-trampoline.c
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 11 Dec 2014 08:21:15 -0800
- Subject: Re: [Patch, MIPS] Fix warning in sysdeps/mips/dl-trampoline.c
- Authentication-results: sourceware.org; auth=none
- References: <872cdd55-2333-4304-9335-3ca5574f30c5 at BAMAIL02 dot ba dot imgtec dot org> <5488ECDE dot 6070702 at redhat dot com>
- Reply-to: <sellcey at imgtec dot com>
On Wed, 2014-12-10 at 20:01 -0500, Carlos O'Donell wrote:
> Why not "switch (l->l_info[VERSYMIDX (DT_VERSYM)] != NULL ? 0 : 1)" to
> avoid the (int) case potentially hiding future type errors?
That seems reasonable but shouldn't it be "switch (l->l_info[VERSYMIDX
(DT_VERSYM)] != NULL ? 1 : 0)" I.e. return 1 if the boolean expression
is true and 0 if the boolean expression is false?
Steve