This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Fix MIPS waitid build [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Wed, 10 Dec 2014 18:50:45 +0000
- Subject: Fix MIPS waitid build [committed]
- Authentication-results: sourceware.org; auth=none
As previously discussed in
<https://sourceware.org/ml/libc-alpha/2012-11/msg00798.html>, MIPS (o32)
waitid has build warnings (now errors) because a function is declared
inline but functions with five-argument syscalls cannot be inlined for
MIPS o32.
This patch disables the -Winline warnings for waitid.c using a
MIPS-specific wrapper file. As it's whole-file disabling, there's no
point in using push and pop, so just DIAG_IGNORE_NEEDS_COMMENT is
used.
Committed.
2014-12-10 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/mips/mips32/waitid.c: New file.
diff --git a/sysdeps/unix/sysv/linux/mips/mips32/waitid.c b/sysdeps/unix/sysv/linux/mips/mips32/waitid.c
new file mode 100644
index 0000000..c18a57c
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/mips/mips32/waitid.c
@@ -0,0 +1,7 @@
+#include <libc-internal.h>
+
+/* MIPS forces a frame pointer for five-argument syscalls using
+ alloca, so resulting in "inlining failed in call to 'do_waitid':
+ function not inlinable". */
+DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Winline");
+#include <sysdeps/unix/sysv/linux/waitid.c>
--
Joseph S. Myers
joseph@codesourcery.com