This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] [PATCH] Remove custom pthread_once implementation on sh.


Torvald Riegel <triegel@redhat.com> wrote:
> This patch removes the custom implementation of pthread_once on sh.  I
> have not tested this, but the generic implementation in
> nptl/pthread_once.c works well on several architectures.
> 
> I don't claim to really understand sh assembly, but given that sh
> defines no HW barriers it seems that the pthread_once fast path would
> just be a normal load and a compiler barrier, which should be as fast in
> C as in assembler.
> 
> Removing the custom implementation will ease maintenance.  If we decide
> not to, I'd at least like to document why in the source of the custom
> custom implementation.
> 
> Thoughts?  OK to commit?

You are right.  The patch is OK.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]