This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] ftell: seek to end only when there are unflushed bytes (BZ #17647)
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Fri, 05 Dec 2014 19:53:36 +0100
- Subject: Re: [PATCH v2] ftell: seek to end only when there are unflushed bytes (BZ #17647)
- Authentication-results: sourceware.org; auth=none
- References: <20141125155404 dot GO12197 at spoyarek dot pnq dot redhat dot com> <547FC7C7 dot 4030000 at redhat dot com> <54805EAD dot 3000605 at linux dot vnet dot ibm dot com> <54808488 dot 1050602 at redhat dot com> <54809D11 dot 5040406 at linux dot vnet dot ibm dot com> <54819F98 dot 5080102 at linux dot vnet dot ibm dot com> <87d27yoyjv dot fsf at igel dot home> <5481DEBD dot 8060507 at linux dot vnet dot ibm dot com> <87388uowbk dot fsf at igel dot home> <5481F321 dot 1080907 at linux dot vnet dot ibm dot com>
Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
> I see now my mistake. What about:
>
> diff --git a/libio/tst-ftell-active-handler.c b/libio/tst-ftell-active-handler.c
> index 44a4fac..0bd9d01 100644
> --- a/libio/tst-ftell-active-handler.c
> +++ b/libio/tst-ftell-active-handler.c
> @@ -365,7 +365,8 @@ do_ftell_test (const char *filename)
> reading. */
> if (test_modes[i].fd_mode != O_WRONLY)
> {
> - char tmpbuf[data_len * char_len];
> + char tmpbuf[data_len * char_len]
> + __attribute__ ((__aligned__ (__alignof__ (wchar_t))));
Or just use wchar_t instead.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."