This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH RFC] Add support for linux memfd_create syscall
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: David Herrmann <dh dot herrmann at gmail dot com>, libc-alpha at sourceware dot org
- Date: Fri, 21 Nov 2014 13:12:28 -0500
- Subject: Re: [PATCH RFC] Add support for linux memfd_create syscall
- Authentication-results: sourceware.org; auth=none
- References: <1413537694-30556-1-git-send-email-dh dot herrmann at gmail dot com>
On 10/17/2014 05:21 AM, David Herrmann wrote:
> The memfd_create() syscall was released with linux-3.17. It's a linux-only
> syscall and returns a shmem file-descriptor backed by anonymous memory
> in a kernel-internal shmem mount.
In general I'm trying hard to make this kind of patch easy to accept.
See the WIP consensus here:
In order to get your patch accepted you have answer some implicit
questions like "How do users use it?" "Why do users need it?"
>From a high-level perspective your patch is missing:
- A test case if possible with non-root privs, or an xcheck test if root
- Documentation for the manual covering the use of the function.
e.g. ./manual/llio.texi, new section under low-level IO, and specify
that it is Linux specific. Feel free to submit your own text to the
linux-kernel man pages to get a new man page created.
Lastly you'll want to review:
The present patch is mechanical in nature and doesn't require copyright
assignment, but adding the test case, and manual entry brings you into
legally significant territory. Do you have a copyright assignment with
the FSF for glibc?