This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/N] [x86_64] Vectorized math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 21 Nov 2014 17:46:17 +0000
- Subject: Re: [PATCH 1/N] [x86_64] Vectorized math functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3ukxk0TrAWPDS_ibScEPkztv=sKhes8iAenyXZdkgkFfg at mail dot gmail dot com>
On Wed, 19 Nov 2014, Andrew Senkevich wrote:
> +#ifndef FUNC_TEST
> +# define FUNC_TEST FUNC
> +#endif
Rather than #ifndef / #define (a discouraged design pattern in glibc,
because it means that typos in the macro name in calling files would not
be detected), I think it would be better to change all existing places
defining FUNC to do:
#define FUNC_TEST(function) FUNC (function)
--
Joseph S. Myers
joseph@codesourcery.com