This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] elf/dl-load.c: Remove local_strdup.

From: Mike Frysinger <vapier at gentoo dot org>
To: Carlos O'Donell <carlos at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 24 Oct 2014 00:09:44 -0400
Subject: Re: [PATCH] elf/dl-load.c: Remove local_strdup.
Authentication-results: sourceware.org; auth=none
References: <5449C26B dot 4070600 at redhat dot com>

On 23 Oct 2014 23:07, Carlos O'Donell wrote:
> This patch removes the apparently superfluous local_strdup.
> I can find no reason for it to be here and the reason for
> it being there is not documented.
> 
> It has been present since 1996-08-15 in a patch that simply
> refactored strlen/malloc/memcpy code into local_strdup without
> changing anything. Probably a conservative change. Why strdup
> was not called is not clear.
> 
> I have verified that building dl-load.c uses the __strdup
> alias so the loader is self-consistent.

lgtm
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] elf/dl-load.c: Remove local_strdup.
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]