This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use INTDEF for powerpc32 compat symbols (bug 14132)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Cc: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Date: Thu, 23 Oct 2014 15:00:00 -0400
- Subject: Re: Don't use INTDEF for powerpc32 compat symbols (bug 14132)
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1410231658161 dot 23533 at digraph dot polyomino dot org dot uk>
On 10/23/2014 12:59 PM, Joseph S. Myers wrote:
> Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
> patch removes the use of INTUSE to rename symbols in
> sysdeps/powerpc/powerpc32/libgcc-compat.S. As the names in question
> are purely internal to this particular object and not used anywhere
> else, it doesn't matter at all whether __*_v_glibc20 or __*_internal
> is used, so this patch just removes the macros in question.
>
> Tested for powerpc32 that stripped installed shared libraries are
> unchanged by this patch.
>
> 2014-10-23 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #14132]
> * sysdeps/powerpc/powerpc32/libgcc-compat.S (__ashldi3_v_glibc20):
> Remove macro definition.
> (__ashrdi3_v_glibc20): Likewise.
> (__lshrdi3_v_glibc20): Likewise.
> (__cmpdi2_v_glibc20): Likewise.
> (__ucmpdi2_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__fixdfdi_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__fixsfdi_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__fixunsdfdi_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__fixunssfdi_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__floatdidf_v_glibc20): Likewise.
> [!_SOFT_FLOAT && !__NO_FPRS__] (__floatdisf_v_glibc20): Likewise.
Looks good to me.
c.