This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add ipc.h for aarch64
- From: Alan Hayward <alan dot hayward at arm dot com>
- To: Christoph Hellwig <hch at lst dot de>, Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 21 Oct 2014 12:01:24 +0100
- Subject: Re: [PATCH] Add ipc.h for aarch64
- Authentication-results: sourceware.org; auth=none
- References: <D06BD949 dot 1758%alan dot hayward at arm dot com> <CAFqB+PzTxktDin8+Ev6tTvcwCumnMn=ouA_QfD_NPkcFhYTgiQ at mail dot gmail dot com> <20141021103153 dot GA1365 at lst dot de>
On 21/10/2014 11:31, "Christoph Hellwig" <hch@lst.de> wrote:
>On Tue, Oct 21, 2014 at 10:52:44AM +0100, Marcus Shawcroft wrote:
>> On 21 October 2014 09:35, Alan Hayward <alan.hayward@arm.com> wrote:
>> > Copied sysdeps/unix/sysv/linux/mips/bits/ipc.h to (new file)
>>
>> We are currently using sysdeps/unix/sysv/linux/bits/ipc.h, I'd prefer
>> we took a copy of that file and changed:
>>
>> unsigned short int mode; /* Read/write permission. */
>> unsigned short int __pad1;
>> ->
>> unsigned int mode; /* Read/write permission. */
>>
>> Rather than take the other changes present in the mips file.
>
>Given that Marcus mentioned that all 64-bit BE Linux targets want
>a 32-bit mode field, how about making a change to
>sysdeps/unix/sysv/linux/bits/ipc.h so that it can be used as-is for all
>these targets?
I did initially think about this, but each architecture seemed to have
subtly different version of the file, even though I think ultimately they
all end up with the same shaped structure. Also, I was shying away from
making a change where I was actively changing many different targets.
I can take a look into creating a unified version.
Alan.