This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/8] nptl: Fix testcases for new pthread cancellation, mechanism
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 9 Oct 2014 16:32:23 +0000
- Subject: Re: [PATCH 3/8] nptl: Fix testcases for new pthread cancellation, mechanism
- Authentication-results: sourceware.org; auth=none
- References: <5435AD7A dot 60400 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1410082310060 dot 4884 at digraph dot polyomino dot org dot uk> <54367F45 dot 5040908 at linux dot vnet dot ibm dot com> <Pine dot LNX dot 4 dot 64 dot 1410091454030 dot 23641 at digraph dot polyomino dot org dot uk> <5436A4C4 dot 2020505 at linux dot vnet dot ibm dot com>
On Thu, 9 Oct 2014, Adhemerval Zanella wrote:
> On 09-10-2014 11:55, Joseph S. Myers wrote:
> > On Thu, 9 Oct 2014, Adhemerval Zanella wrote:
> >
> >> open/open64 | tst-cancel4.c | no | yes |
> >> pread/pread64 | tst-cancel4.c | no | yes |
> >> pwrite/pwrite64 | tst-cancel4.c | no | yes |
> > I don't think pairing like that is legitimate. Each of those pairs is two
> > separate functions, and only one of each pair is tested in tst-cancel4.c.
> > The *64 functions need testing to at least the same extent.
> >
> Right, will be suffice to add proper tests for open64/pread64/pwrite64 using
> __USE_LARGEFILE64 on tst-cancel4.c to cover such cases?
You shouldn't need __USE_LARGEFILE64 (_GNU_SOURCE is used by default,
which implies __USE_LARGEFILE64). Yes, I think adding tests of those
functions similar to the existing ones of open/pread/pwrite should
suffice.
--
Joseph S. Myers
joseph@codesourcery.com