This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] nptl: Fix testcases for new pthread cancellation, mechanism
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Fri, 19 Sep 2014 17:02:05 +0000
- Subject: Re: [PATCH 3/4] nptl: Fix testcases for new pthread cancellation, mechanism
- Authentication-results: sourceware.org; auth=none
- References: <541C2901 dot 1050609 at linux dot vnet dot ibm dot com> <541C2B18 dot 4090107 at linux dot vnet dot ibm dot com> <541C2DDA dot 6050204 at linux dot vnet dot ibm dot com>
On Fri, 19 Sep 2014, Adhemerval Zanella wrote:
> This patches fixes the NPTL testcase that assumes the old behavior and
Do the fixes result in tests that work both with and without the main
changes? If so, they should go first. (In general, for bisectability
either you fix tests first to work both with and without the main changes,
or the test fixes need to go in the same commit as the main changes even
if posted separately for convenience.)
> also remove the tst-cancel-wrappers.sh test (which checks for symbols
> that does not exist anymore).
Is there a better way of achieving the substance of this test (i.e.
verifying that all those functions are cancellable) that still works after
the patch?
--
Joseph S. Myers
joseph@codesourcery.com