This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 19/19] Define NOT_IN when building outside glibc.
- From: Richard Henderson <rth at twiddle dot net>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha at sourceware dot org
- Date: Fri, 22 Aug 2014 06:50:54 -0700
- Subject: Re: [PATCH 19/19] Define NOT_IN when building outside glibc.
- Authentication-results: sourceware.org; auth=none
- References: <1408618663-2281-1-git-send-email-siddhesh at redhat dot com> <1408618663-2281-20-git-send-email-siddhesh at redhat dot com>
On 08/21/2014 03:57 AM, Siddhesh Poyarekar wrote:
> * nptl_db/structs.def [!_LIBC]: Define NOT_IN.
> ---
> nptl_db/structs.def | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/nptl_db/structs.def b/nptl_db/structs.def
> index ea8b7ac..82e7157 100644
> --- a/nptl_db/structs.def
> +++ b/nptl_db/structs.def
> @@ -16,6 +16,10 @@
> License along with the GNU C Library; if not, see
> <http://www.gnu.org/licenses/>. */
>
> +#ifndef _LIBC
> +# define NOT_IN(lib) (0)
> +#endif
I'm not especially convinced by the readability improvement of NOT_IN, and I'm
particularly confused by a NOT_IN that defaults to false.
r~