Re: [PATCH] Sync up error.c with gnulib

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Wed, Jul 09, 2014 at 11:41:09AM +0100, Will Newton wrote:
> On 9 July 2014 11:33, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> > hi,
> >
> > The following patch should sync up the glibc version of error.c with
> > gnulib.  There are a few changes that are pending inclusion into
> > gnulib; I have posted them to bug-gnulib but the email is probably
> > held in moderation.
> >
> > Summary of changes:
> >
> > - Use of !_LIBC instead of HAVE_CONFIG_H
> > - Code changes in [!_LIBC] that don't affect us
> > - Minor formatting changes
> > - Use __builtin_expect in shared code
> > - Define some macros in [_LIBC] that are used in gnulib but never
> >   defined in glibc (change proposed in gnulib)
> > - Flip macro check for STRERROR_R_CHAR_P so that it does not throw a
> >   warning (change proposed in gnulib)
> 
> AFAICT STRERROR_R_CHAR_P is not defined in gnulib any more so it
> should probably be removed altogether.

Oh yeah, thanks for pointing that out.  I'll update my patches.

Siddhesh

Attachment: pgpRP3CuGC9PQ.pgp
Description: PGP signature