This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [ping] nptl: Fix abort in case of set*id failure

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Florian Weimer <fweimer at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Wed, 9 Jul 2014 16:29:52 +0530
Subject: Re: [PATCH] [ping] nptl: Fix abort in case of set*id failure
Authentication-results: sourceware.org; auth=none
References: <20140428120545 dot 20B0643994596 at oldenburg dot str dot redhat dot com> <53B3F87E dot 5090507 at redhat dot com> <20140709060923 dot GN609 at spoyarek dot pnq dot redhat dot com> <53BD1CB0 dot 7030508 at redhat dot com>

On Wed, Jul 09, 2014 at 12:42:56PM +0200, Florian Weimer wrote:
> Doesn't the stack_cache_lock in __nptl_setxid prevent this?  I don't know
> what it does to async-signal-safety, and there is likely some issue here,
> but I think your A/B case is properly locked out.

Of course, I overlooked the lock.  The lock could then deadlock if
thread A is holding the lock and it is interrupted by another signal
and the handler also calls setxid.

Siddhesh

Attachment: pgpBN1tYZIMVp.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] [ping] nptl: Fix abort in case of set*id failure
  - From: Florian Weimer

References:
- [PATCH] [ping] nptl: Fix abort in case of set*id failure
  - From: Florian Weimer
- Re: [PATCH] [ping] nptl: Fix abort in case of set*id failure
  - From: Siddhesh Poyarekar
- Re: [PATCH] [ping] nptl: Fix abort in case of set*id failure
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]