This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] stdlib/tst-strtod-overflow: Bump timeout up yet more
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Mon, 23 Jun 2014 01:54:56 +0100
- Subject: [PATCH] stdlib/tst-strtod-overflow: Bump timeout up yet more
- Authentication-results: sourceware.org; auth=none
Hi,
In our routine testing I observed that stdlib/tst-strtod-overflow is very
slow, especially on targets using soft-float or QEMU (where soft-float is
used internally), enough to time out even on slow boards we have that have
TIMEOUTFACTOR already bumped from the default of 1 up to 75.
No other test case requires such a long timeout -- all the other
succeeding cases fit within their timeouts scaled by TIMEOUTFACTOR on
these boards. As such I think it's counter-productive to require
TIMEOUTFACTOR to be set as high as 450 globally for this lone outlier as
the value affects overall testing duration where there are test cases that
genuinely time out due to a defect. Therefore I propose the following
change that makes stdlib/tst-strtod-overflow pass on these slow boards
with TIMEOUTFACTOR of 75.
OK to apply?
2014-06-23 Maciej W. Rozycki <macro@codesourcery.com>
* stdlib/tst-strtod-overflow.c (TIMEOUT): Bump up to 30.
Maciej
Index: glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c
===================================================================
--- glibc-fsf-trunk-quilt.orig/stdlib/tst-strtod-overflow.c 2014-06-17 15:50:29.991694082 +0100
+++ glibc-fsf-trunk-quilt/stdlib/tst-strtod-overflow.c 2014-06-23 01:49:28.082011090 +0100
@@ -45,5 +45,5 @@ do_test (void)
}
#define TEST_FUNCTION do_test ()
-#define TIMEOUT 5
+#define TIMEOUT 30
#include "../test-skeleton.c"