This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nptl-sparc] Move SPARC code out of nptl/sysdeps/sparc/.
- From: David Miller <davem at davemloft dot net>
- To: roland at hack dot frob dot com
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 12 Jun 2014 15:58:20 -0700 (PDT)
- Subject: Re: [PATCH roland/nptl-sparc] Move SPARC code out of nptl/sysdeps/sparc/.
- Authentication-results: sourceware.org; auth=none
- References: <20140612213633 dot 3E65B2C39BF at topped-with-meat dot com> <20140612 dot 152432 dot 18212249129943579 dot davem at davemloft dot net> <20140612223222 dot AC2A12C39BF at topped-with-meat dot com>
From: Roland McGrath <roland@hack.frob.com>
Date: Thu, 12 Jun 2014 15:32:22 -0700 (PDT)
>> Sorry for not reviewing this earlier, I planned to do it earlier today.
>>
>> It looks fine to me, and if there should be some fallout I'll fix it up
>> for you.
>
> Thanks. I've merged the branch, getting these four commits:
>
> febf6cc Move SPARC public headers out of nptl/
> e268224 Move SPARC code out of nptl/sysdeps/sparc/.
> b0725f4 SPARC: Define TLS_DEFINE_INIT_TP
> b14368b SPARC: Convert fork.c to arch-fork.h
>
> What would be really great is if you could RSN do the clone and vfork
> consolidation as most other machines have done now. That should leave only
> the simple renames left to entirely get rid of
> nptl/sysdeps/unix/sysv/linux/sparc/.
Ok, I just have to deal with this link failure first:
/home/davem/src/GIT/GLIBC/build-sparcv9/libc_pic.os: In function `fork_handler_alloc':
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:71: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:71: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:71: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/build-sparcv9/libc_pic.os: In function `__linkin_atfork':
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:114: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:114: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/build-sparcv9/libc_pic.os:/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:114: more un\
defined references to `__fork_handlers' follow
/home/davem/src/GIT/GLIBC/build-sparcv9/libc_pic.os: In function `__libc_pthread_init':
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/libc_pthread_init.c:44: undefined reference to `__fork_generation_pointer'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/libc_pthread_init.c:44: undefined reference to `__fork_generation_pointer'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/libc_pthread_init.c:44: undefined reference to `__fork_generation_pointer'
/home/davem/src/GIT/GLIBC/build-sparcv9/libc_pic.os: In function `free_mem':
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:128: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:128: undefined reference to `__fork_handlers'
/home/davem/src/GIT/GLIBC/glibc/nptl/../nptl/sysdeps/unix/sysv/linux/register-atfork.c:128: undefined reference to `__fork_handlers'
/usr/bin/ld: /home/davem/src/GIT/GLIBC/build-sparcv9/libc.so: hidden symbol `__fork_generation_pointer' isn't defined
/usr/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status