This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] remove one nested function from nptl/allocatestack.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 5 Jun 2014 11:31:10 -0700 (PDT)
- Subject: Re: [PATCH] remove one nested function from nptl/allocatestack.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdw9_bgxZ3UOMNnnMC7EXtyUbBs5AkHvEF3jT0uB3GhaSg at mail dot gmail dot com> <20140604171623 dot 362652C39B4 at topped-with-meat dot com> <20140605090455 dot GB9145 at spoyarek dot pnq dot redhat dot com>
> + /* We always add at the beginning of the list. So in this case we
> + only need to check the beginning of these lists to see if the
> + pointers at the head of the list are inconsistent. */
> + list_t *l = NULL;
> +
> + if (stack_used.next->prev != &stack_used)
> + l = &stack_used;
> + else if (stack_cache.next->prev != &stack_cache)
> + l = &stack_cache;
> +
> + if (l)
No implicit Boolean coercion.
Otherwise this is fine.