This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- From: Richard Henderson <rth at twiddle dot net>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, libc-alpha at sourceware dot org
- Date: Fri, 30 May 2014 12:03:31 -0700
- Subject: Re: [PATCH roland/nptl-sh] SH: Consolidate NPTL/non versions of vfork
- Authentication-results: sourceware.org; auth=none
- References: <20140529230926 dot 133C22C3C21 at topped-with-meat dot com> <20140530 dot 134750 dot 439128275 dot kkojima at rr dot iij4u dot or dot jp> <20140530161958 dot 15CE72C39B6 at topped-with-meat dot com> <5388C560 dot 9040402 at twiddle dot net> <20140530184006 dot C121F2C39C8 at topped-with-meat dot com>
On 05/30/2014 11:40 AM, Roland McGrath wrote:
>> You should be able to reuse the Alpha pt-vfork.S to get the compat symbols
>> correct. C.f. Alpha's vfork.S for which symbols to define there.
>
> Thanks. I've updated the roland/nptl-sh branch to do this.
>
You missed the bit about the symbols:
The function should be defined as __libc_vfork, and the vfork, __vfork, and
libc_hidden_def should only be defined if !NOT_IN_libc.
r~