This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/6] aarch64: Merge rtld_errno offset with memory reference
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: Roland McGrath <roland at hack dot frob dot com>, GNU C Library <libc-alpha at sourceware dot org>, Richard Henderson <rth at redhat dot com>
- Date: Sat, 24 May 2014 08:31:55 +0100
- Subject: Re: [PATCH 1/6] aarch64: Merge rtld_errno offset with memory reference
- Authentication-results: sourceware.org; auth=none
- References: <1400619378-7262-1-git-send-email-rth at twiddle dot net> <1400619378-7262-2-git-send-email-rth at twiddle dot net> <20140523203142 dot 8A8D12C3B6D at topped-with-meat dot com> <537FB0EB dot 3090307 at twiddle dot net>
On 23 May 2014 21:34, Richard Henderson <rth@twiddle.net> wrote:
> It's required in the context of the add, and not required (but accepted) in the
> context of an address operand.
The relevant documentation here is: PRD03-GENC-010197 section 4.1.
The # is optional on all immediates. The spec also requires that
disassemblers should always emit the # for readability.
> Personally, I prefer not using # in an address; which form do the AArch64
> maintainers prefer?
I think we should insert the # for all immediates.
I'm curious about Richards statement above, have you seen a scenario
where the assembler refuses to accept the # on an add? I doubled
checked this particular case with and without using trunk gas and it
seems to be fine.
Cheers
/Marcus