This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/6] aarch64: Tidy syscall error check


On 05/21/2014 01:28 AM, Will Newton wrote:
> On 20 May 2014 21:56, Richard Henderson <rth@twiddle.net> wrote:
>> From: Richard Henderson <rth@redhat.com>
>>
>> Move the error branch from the PSEUDO_RET macro to the PSEUDO macro.
>> This is in line with other architectures, and will enable further improvments.
>>
>>         * sysdeps/unix/sysv/linux/aarch64/nptl/sysdep-cancel.h (PSEUDO):
>>         Branch to .Lsyscall_error on error.  Do not call DOARGS/UNDOARGS.
> 
> It's not clear to me why the DOARGS/UNDOARGS change is part of this
> patch. Could you elaborate?

Oops, incomplete splitting of the patches.

(1) If they did something, their placement is buggy, as they're not properly
nested around the DO_CALL.  But...

(2) They do nothing on aarch64, since all parameters are already in registers.
 So why should we pretend to invoke them?


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]