This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: make nptl no longer an add-on?
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Fri, 9 May 2014 09:58:52 -0700 (PDT)
- Subject: Re: make nptl no longer an add-on?
- Authentication-results: sourceware.org; auth=none
- References: <20140508193058 dot 722792C3992 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1405082113580 dot 12485 at digraph dot polyomino dot org dot uk>
> * Checking for identical disassembly of installed libraries is important
> (though there may well be cases with paths in assertions and similar that
> mean you can't get identical disassembly).
Agreed. I intend to ask machine maintainers' testing and approval for
machines I cannot easily test myself.
> So, you need to check #include paths carefully in all moved files, *and*
> check for #includes in other files that might include a file that's moved
> but depend on the exact path to that file.
Indeed.
> Once you no longer have the separate sysdeps tree in nptl, I think
> anything needing a particular sysdeps file can just include
> <sysdeps/whatever> without needing any "../" to force the file to be found
> from a particular sysdeps tree.
Correct.
> There are plenty of cases where linux/CPU/nptl/vfork.S does some #defines
> then includes linux/CPU/vfork.S, for example.
I'll discover all these kinds of cases along the way and do the right thing.