This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix HP_SMALL_TIMING_AVAIL undef warnings
- From: Steve Ellcey <sellcey at mips dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 28 Apr 2014 09:24:59 -0700
- Subject: Re: [Patch] Fix HP_SMALL_TIMING_AVAIL undef warnings
- Authentication-results: sourceware.org; auth=none
- References: <ad1e0a7b-521b-44e3-b7bf-ddb7b3b45fba at BAMAIL02 dot ba dot imgtec dot org> <CANu=DmhDfkKzqFbR1Qvxu61o2hVnUwB+MYxvhZ6y4qy4X3LZzg at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1404281449270 dot 16435 at digraph dot polyomino dot org dot uk>
On Mon, 2014-04-28 at 14:53 +0000, Joseph S. Myers wrote:
> On Mon, 28 Apr 2014, Will Newton wrote:
>
> > This looks like it is the right thing to do, however I believe the
> > warnings will persist on:
> >
> > ia64
> > x86_64
> > i386
> > powerpc32
> > powerpc64
> > sparc32
> > sparc64
> >
> > Which all use their own hp-timing.h.
>
> Indeed. For such a patch you need to:
It seems a bit ugly to have to define
HP_SMALL_TIMING_AVAIL as 0 in 8 different hp-timing.h header files.
Would the idea of each of these hp-timing.h header files including the
default hp-timing.h header file and then only overriding the macros they
need to redefine be considered acceptable? I see a few uses of
"#include_next" in glibc but not in any header files where a platform is
redefining a generic header. Those all seem to be complete
replacements. How about a new header file of default macro definitions
(not necessarily just the timing macros)? Is that something that could
be considered to provide default values for macros? Or has that idea
already been dismissed?
Steve Ellcey
sellcey@mips.com