This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH][BZ #16876] Fix typo in nptl/sockperf.c
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: libc-alpha at sourceware dot org
- Date: Sun, 27 Apr 2014 18:02:57 +0200
- Subject: [PATCH][BZ #16876] Fix typo in nptl/sockperf.c
- Authentication-results: sourceware.org; auth=none
Hi, as described in
https://sourceware.org/bugzilla/show_bug.cgi?id=16876
relevant if test does not make sense as it tests if pointer is negative.
A clisock variable is unused outside of this test so we should fix it to
intended behaviour.
OK to commit?
[BZ #16876]
* nptl/sockperf.c (client): Check if socket exist.
diff --git a/nptl/sockperf.c b/nptl/sockperf.c
index 740fb88..2d4b872 100644
--- a/nptl/sockperf.c
+++ b/nptl/sockperf.c
@@ -71,7 +71,6 @@ client (void *arg)
struct thread_param *param = arg;
unsigned int cnt;
unsigned int nserv = param->nserv;
- int clisock[nserv];
struct pollfd servpoll[nserv];
struct sockaddr_un servaddr;
socklen_t servlen;
@@ -102,7 +101,7 @@ client (void *arg)
for (cnt = 0; cnt < nserv; ++cnt)
{
servpoll[cnt].fd = socket (AF_UNIX, SOCK_STREAM, 0);
- if (clisock < 0)
+ if (servpoll[cnt].fd < 0)
{
puts ("cannot create socket in client");
return NULL;