This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/4] Nios II port submission, sysdeps/nios2 parts
- From: Will Newton <will dot newton at linaro dot org>
- To: Chung-Lin Tang <chunglin_tang at mentor dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, "Joseph S. Myers" <joseph at codesourcery dot com>, Sandra Loosemore <sandra at codesourcery dot com>
- Date: Tue, 22 Apr 2014 09:42:02 +0100
- Subject: Re: [PATCH v2 2/4] Nios II port submission, sysdeps/nios2 parts
- Authentication-results: sourceware.org; auth=none
- References: <5350FD1F dot 5030600 at mentor dot com>
On 18 April 2014 11:23, Chung-Lin Tang <chunglin_tang@mentor.com> wrote:
> Updated after Joseph's first review.
>
> Note that the suggested DEFAULT_STACK_PERMS change to use a
> non-executable stack has not been done yet, as we haven't coordinated
> this change completely with Altera yet (no such kernel available yet).
> This will probably be completed before committing upstream.
>
> So far, the nios2 port's base version is still set at GLIBC_2.20. I'm
> not sure if we'll have to increment this by the time of committing...
One small thing I noticed. It looks like you are encrypting the frame
pointer in setjmp/longjmp. On ARM this broke e.g. Ruby which relies on
having pointers in jmp_buf unencrypted (lr and sp can safely be
encrypted).
> Thanks,
> Chung-Lin
>
> * sysdeps/nios2/Implies: New file.
> * sysdeps/nios2/Makefile: New file.
> * sysdeps/nios2/Subdirs: New file.
> * sysdeps/nios2/Versions: New file.
> * sysdeps/nios2/__longjmp.S: New file.
> * sysdeps/nios2/abort-instr.h: New file.
> * sysdeps/nios2/backtrace.c: New file.
> * sysdeps/nios2/bsd-_setjmp.S: New file.
> * sysdeps/nios2/bsd-setjmp.S: New file.
> * sysdeps/nios2/configure.ac: New file.
> * sysdeps/nios2/configure: New generated file.
> * sysdeps/nios2/crti.S: New file.
> * sysdeps/nios2/crtn.S: New file.
> * sysdeps/nios2/dl-init.c: New file.
> * sysdeps/nios2/dl-machine.h: New file.
> * sysdeps/nios2/dl-sysdep.h: New file.
> * sysdeps/nios2/dl-tls.h: New file.
> * sysdeps/nios2/dl-trampoline.S: New file.
> * sysdeps/nios2/gccframe.h: New file.
> * sysdeps/nios2/gmp-mparam.h: New file.
> * sysdeps/nios2/jmpbuf-offsets.h: New file.
> * sysdeps/nios2/jmpbuf-unwind.h: New file.
> * sysdeps/nios2/ldsodefs.h: New file.
> * sysdeps/nios2/libc-tls.c: New file.
> * sysdeps/nios2/libm-test-ulps: New file.
> * sysdeps/nios2/machine-gmon.h: New file.
> * sysdeps/nios2/math-tests.h: New file.
> * sysdeps/nios2/math_private.h: New file.
> * sysdeps/nios2/memusage.h: New file.
> * sysdeps/nios2/preconfigure: New file.
> * sysdeps/nios2/s_fma.c: New file.
> * sysdeps/nios2/s_fmaf.c: New file.
> * sysdeps/nios2/setjmp.S: New file.
> * sysdeps/nios2/shlib-versions: New file.
> * sysdeps/nios2/sotruss-lib.c: New file.
> * sysdeps/nios2/stackguard-macros.h: New file.
> * sysdeps/nios2/stackinfo.h: New file.
> * sysdeps/nios2/start.S: New file.
> * sysdeps/nios2/sysdep.h: New file.
> * sysdeps/nios2/tls-macros.h: New file.
> * sysdeps/nios2/tst-audit.h: New file.
> * sysdeps/nios2/bits/endian.h: New file.
> * sysdeps/nios2/bits/fenv.h: New file.
> * sysdeps/nios2/bits/link.h: New file.
> * sysdeps/nios2/bits/setjmp.h: New file.
> * sysdeps/nios2/nptl/pthread_spin_lock.c: New file.
> * sysdeps/nios2/nptl/pthread_spin_trylock.c: New file.
> * sysdeps/nios2/nptl/pthreaddef.h: New file.
> * sysdeps/nios2/nptl/tcb-offsets.sym: New file.
> * sysdeps/nios2/nptl/tls.h: New file.
> * sysdeps/nios2/soft-fp/sfp-machine.h: New file.
--
Will Newton
Toolchain Working Group, Linaro