Re: [PATCH] malloc/obstack: Merge obstack code back from gnulib

[Roland McGrath <roland at hack dot frob dot com>]

As a general rule, we want each change described fully in the ChangeLog and
subject to our independent review.  We have to be this anal because we have
some issues to worry about that gnulib doesn't (and of course vice versa).
It's certainly worthwhile to mention at the top of the log paragraph that
you're sync'ing up with gnulib, but the individual changes need to be
described (and reviewed fully).

These particular changes look mostly quite harmless.  But the principle
stands.  The ones that are literally cosmetic (changing comments and
formatting) can be logged trivially (no need to cite every function in the
normal way, for example).  Adding attributes and such, while also harmless
in the cases I saw, needs to be logged explicitly.  Renaming functions
absolutely must be logged--most especially for globals, and that is most
likely not at all harmless and needs both careful review and your testimony
that you tested the changes in a libc build including 'make check' (start
with the quicker 'make check-abi' to confirm or refute my suspicion about
why the change might be bad before wading through 'make check' and
identifying all possible regressions).


Thanks,
Roland