This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Remove x86 assembler rwlock code
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org, Andi Kleen <ak at odo dot jf dot intel dot com>
- Date: Mon, 24 Mar 2014 09:43:50 +0100
- Subject: Re: [PATCH 2/2] Remove x86 assembler rwlock code
- Authentication-results: sourceware.org; auth=none
- References: <1395100891-22307-1-git-send-email-andi at firstfloor dot org> <1395100891-22307-2-git-send-email-andi at firstfloor dot org>
On Mon, Mar 17, 2014 at 05:01:31PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@odo.jf.intel.com>
>
> With the recent tuning the C version of rwlocks is basically the same
> performance as the x86 assembler version for uncontended locks (with a
> a few cycles near the run-to-run variability). For others it should not
> matter anyways.
>
> So remove the assembler code and use the C version like other
> architectures.
>
What benchmark did you used? I would be ok with this when I see data.