This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/Versions.def] Get rid of Versions.def source file
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Fri, 21 Mar 2014 13:18:30 -0700 (PDT)
- Subject: Re: [PATCH roland/Versions.def] Get rid of Versions.def source file
- Authentication-results: sourceware.org; auth=none
- References: <20140228214559 dot BD8BF744B6 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1403211805400 dot 4557 at digraph dot polyomino dot org dot uk>
> Which Versions file should be used when?
Technically it doesn't matter. Practically, as long as it gets a comment
explaining its purpose, it's unlikely to cause a maintenance headache
wherever it is. What seems most sensible is for it to be in a Versions
file in the same directory as the (first) source file that causes the need
for it. That would be sysdeps/generic/ at the moment, but I don't know any
reason why those files (or any files other than headers) shouldn't be in
elf/ (or whatever appropriate subdir) rather than sysdeps/generic/. So
maybe first clean things up by moving the source files and Makefile bits to
elf/, and then add GLIBC_2.2.5 to elf/Versions. (Actually it doesn't
matter which order those are done in, but cleanup-first is usually the best
way to avoid cleanup-forgotten.)
I'm a bit confused about the situation on mips. Was its check-abi already
broken before my Versions.def change? The intent of that change was that
it have no material effect on any build output.
Thanks,
Roland