This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390:
- From: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 19 Mar 2014 17:06:01 +0100
- Subject: Re: [PATCH] S/390:
- Authentication-results: sourceware.org; auth=none
- References: <lfuu4e$uam$3 at ger dot gmane dot org> <Pine dot LNX dot 4 dot 64 dot 1403141415341 dot 17775 at digraph dot polyomino dot org dot uk> <lg9f99$e01$1 at ger dot gmane dot org> <Pine dot LNX dot 4 dot 64 dot 1403181408000 dot 29154 at digraph dot polyomino dot org dot uk>
On 03/18/2014 03:11 PM, Joseph S. Myers wrote:
On Tue, 18 Mar 2014, Stefan Liebler wrote:
I fixed the header as mentioned. The tests pass on s390/s390x.
Unifying s390/s390-32/bits/wordsize.h and s390/s390-64/wordsize.h to
s390/bits/wordsize.h leads to a build error:
I suppose there must be some non-obvious sysdeps directory ordering issue,
so another bits/wordsize.h gets found if you unify those headers?
yes that´s right. The used one is sysdeps/wordsize-32/bits/wordsize.h
(on s390), which is the next include-dir specified by gcc invocation:
-Isysdeps/s390/s390-32 -Isysdeps/wordsize-32 -Inptl/sysdeps/s390
-Isysdeps/s390
The other header-files in sysdeps/s390/bits/ are not available in
-Isysdeps/wordsize-32 -Inptl/sysdeps/s390, so there it´s no problem.
Is it possible to change the directory ordering?
2014-03-18 Stefan Liebler <stli@linux.vnet.ibm.com>
[BZ #16712]
* sysdeps/s390/s390-32/bits/wordsize.h
(__WORDSIZE32_SIZE_ULONG): New define.
* sysdeps/s390/s390-64/bits/wordsize.h
(__WORDSIZE32_SIZE_ULONG): Likewise.
* sysdeps/generic/stdint.h (SIZE_MAX):
Define as UL if __WORDSIZE32_SIZE_ULONG.
OK.
I believe there's a previous approval of mine for (part of) a patch of
yours <https://sourceware.org/ml/libc-alpha/2014-02/msg00819.html> that
hasn't been committed.
Thanks for the hint. I´ll forward the part of the patch
(posix/Makefile: before-compile += testcases.h ptestcases.h) to Andreas
Krebbel, so he can commit it.
Bye