This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PLEASE FIX NOW! make check-abi exits zero on failure


Since you want a quick fix, I've applied this patch.  (Really the 
subdirectory check-abi targets should generate .sum files and then 
toplevel combine those, just like the tests and xtests targets.)

diff --git a/ChangeLog b/ChangeLog
index c7e121d..b007a2e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-03-18  Joseph Myers  <joseph@codesourcery.com>
+
+	* Makerules [!subdir] (check-abi): Exit with error status if a
+	test failed.
+
 2014-03-17  Joseph Myers  <joseph@codesourcery.com>
 
 	* math/libm-test.inc (nearbyint_test_data): Include all tests used
diff --git a/Makerules b/Makerules
index 008e80a..4427f4e 100644
--- a/Makerules
+++ b/Makerules
@@ -1257,6 +1257,7 @@ subdir_check-abi: check-abi
 subdir_update-abi: update-abi
 else
 check-abi: subdir_check-abi
+	if grep -q '^FAIL:' $(objpfx)*/check-abi*.test-result; then exit 1; fi
 update-abi: subdir_update-abi
 endif
 

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]