Re: [RFC] Make _FILE_OFFSET_BITS=64 default.

[Mike Frysinger <vapier at gentoo dot org>]

On Thu 13 Mar 2014 05:20:57 Rich Felker wrote:
> On Thu, Mar 13, 2014 at 05:16:08AM -0400, Mike Frysinger wrote:
> > diff --git a/io/Makefile b/io/Makefile
> > index 8a6562e..77a1907 100644
> > --- a/io/Makefile
> > +++ b/io/Makefile
> > @@ -99,7 +99,7 @@ CFLAGS-fallocate.c = -fexceptions
> > 
> >  CFLAGS-fallocate64.c = -fexceptions
> >  CFLAGS-sync_file_range.c = -fexceptions
> > 
> > -CFLAGS-test-stat.c = -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE
> > +CFLAGS-test-stat.c = -U_FILE_OFFSET_BITS -D_FILE_OFFSET_BITS=64
> > -D_LARGEFILE64_SOURCE
>
> If this happens to work, it's purely by chance/redundancy. -U
> overrides all -D for the same identifier, even subsequent ones.

if your compiler driver is unreasonable and isn't sane, then i'm not sure how 
that's our problem.  we're already relying on sane behavior -- see how 
_FORTIFY_SOURCE is used in the tree.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.