This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [ARM] ] Add support for fenv_private on ARM


On Thu, 6 Mar 2014, Wilco wrote:

> +#if ARM_HAVE_VFP

ARM_HAVE_VFP isn't suitable for use in #if; see the 
sysdeps/unix/sysv/linux/arm/arm-features.h definition.  You need either a 
new macro meaning "VFP is known at compile time to be available", or to 
move to checks with "if" inside the functions.

(The case of a soft-float build, VFP hardware available at runtime - the 
one addressed by "if" conditionals - has other problems with exceptions 
and rounding modes, that I think would best be addressed by use of IFUNCs 
in libgcc for the relevant RTABI functions; see bug 10064.  Anyway, the 
present patch is purely an optimization, so there's certainly no need for 
it to cover all cases as long as it doesn't break them.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]