This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Multiarch optimization for strncat on PowerPC64
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Thu, 06 Mar 2014 09:38:33 -0300
- Subject: Re: [PATCH] Multiarch optimization for strncat on PowerPC64
- Authentication-results: sourceware.org; auth=none
- References: <5310CE87 dot 7040406 at linux dot vnet dot ibm dot com> <5315E8D2 dot 2010201 at linux dot vnet dot ibm dot com> <53184F47 dot 3030307 at linux dot vnet dot ibm dot com>
On 06-03-2014 07:34, R Vidya wrote:
> +#define FRAMESIZE (FRAME_MIN_SIZE+112)
Your implementation does not uses 112 bytes of stack, I think you mean plus 3 (the r29, r30, r31)
you save.
> +
> +L(a4):
> + cmpdi r29, 0 /* if "n" is already zero ; we skip */
> + beq+ L(align4align)
> +
> + mtctr r29 /* process left over bytes in "n" */
> +unaligned1:
Missing L(...) on this label.
> +
> +L(a8):
> + cmpdi r29, 0 /* if "n" is already zero ; we skip */
> + beq+ L(align8align)
> +
> + mtctr r29 /* process left over bytes in "n" */
> +unaligned0:
Missing L(...) on this label.
Besides that, it is ok.