This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 5 Mar 2014 14:55:25 +0000
- Subject: Re: [PATCH] hppa: Add _STACK_GROWS_* cases to pthread_attr_[sg]etstack.
- Authentication-results: sourceware.org; auth=none
- References: <5316B1E5 dot 5070100 at redhat dot com>
On Wed, 5 Mar 2014, Carlos O'Donell wrote:
> Can't impact any other targets because of the conditionals.
For this sort of thing I suggest comparing before-and-after disassembly of
the installed shared libraries on some other system (e.g. x86_64) to
confirm there are no typos making it affect other systems. I think
_STACK_GROWS_* changes can be considered obvious if (a) the text after
preprocessing is intended to be unchanged on _STACK_GROWS_DOWN systems,
(b) it's confirmed that the disassembly of the installed shared libraries
is unchanged (modulo anything arising from different line numbers in
assertions) and (c) it's confirmed it does have the desired effect on
hppa. That should cover most of these changes.
--
Joseph S. Myers
joseph@codesourcery.com