This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #16632: Disable _SVID_SOURCE/_BSD_SOURCE warning if _DEFAULT_SOURCE is defined.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 25 Feb 2014 13:28:59 -0500
- Subject: Re: [PATCH] BZ #16632: Disable _SVID_SOURCE/_BSD_SOURCE warning if _DEFAULT_SOURCE is defined.
- Authentication-results: sourceware.org; auth=none
- References: <530CC12D dot 2000608 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1402251755000 dot 25387 at digraph dot polyomino dot org dot uk>
On 02/25/2014 12:55 PM, Joseph S. Myers wrote:
> Seems reasonable to me.
Thanks. Checked in.
commit ade40b10ff5fa59a318cf55b9d8414b758e8df78
Author: Carlos O'Donell <carlos@redhat.com>
Date: Tue Feb 25 13:23:25 2014 -0500
BZ #16632: Change [_BSD/_SVID]_SOURCE warning.
Source packages that need to support both 2.19 and
2.20 will need to decide to use _BSD_SOURCE and
_SVID_SOURCE vs. _DEFAULT_SOURCE.
The difficulty in making that decision is that
__GLIBC_MINOR__ is itself defined in features.h,
but you want to set the feature test macros before
including features.h.
Therefore to ease the transition we should disable
the warning if _DEFAULT_SOURCE is also defined.
https://sourceware.org/ml/libc-alpha/2014-02/msg00666.html
https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes
Cheers,
Carlos.