This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Allow inclusion of sysdep.h and sys/auxv.h at build time
- From: Adam Conrad <adconrad at 0c3 dot net>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 20 Feb 2014 16:18:01 -0700
- Subject: Re: [PATCH] Allow inclusion of sysdep.h and sys/auxv.h at build time
- Authentication-results: sourceware.org; auth=none
- References: <20140220063943 dot GV22181 at 0c3 dot net> <53068C46 dot 5070909 at redhat dot com>
On Thu, Feb 20, 2014 at 06:14:14PM -0500, Carlos O'Donell wrote:
>
> This looks good to me, but I'm curious what this actually fixes?
elf/tst-auxv.c includes misc/sys/auxv.h, which ends up not actually
being included due to the guard overlap, and getauxval becomes an
implicit declaration and implicit pointer conversion which means, at
best, the test isn't actually testing what it thinks it is and, at
worst, it'll crash and burn on platforms where implict pointer
conversion is a Very Bad Thing.
... Adam