This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/4] Add a signal-safe malloc replacement


I see build warnings on x86_64:

dl-misc.c:391:3: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
dl-misc.c:435:14: warning: assignment from incompatible pointer type [enabled by default]
dl-misc.c: In function '__signal_safe_free':
dl-misc.c:459:51: warning: initialization from incompatible pointer type [enabled by default]
dl-misc.c: In function '__signal_safe_realloc':
dl-misc.c:476:51: warning: initialization from incompatible pointer type [enabled by default]

Please check for new warnings arising from patches and try to keep the 
build warning-free.  (I'd quite like to use -Werror so you don't need to 
check manually for warnings, but that would require working out a standard 
approach for the cases where warnings are hard to fix, possibly arising 
from compiler bugs and possibly architecture-dependent.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]