This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, Dec 18, 2013 at 4:12 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote: > On Wed, Dec 18, 2013 at 4:06 PM, Andrew Hunter <ahh@google.com> wrote: > >> I think the proper fix is to reorder the patches -- move Factor out >> _dl_clear_dtv before this one (having it just call free, not >> signal_safe_). Then apply this patch and replace the free with >> signal_safe_free here.) > > Aha. I haven't looked at patch 3 (until now). > > I agree, applying slightly modified patch 3, then patch 2, is the way to go. > > I'll test and commit in that order. Tested attached patch on Linux/x86_64 and i686. Committed as 1f33d36a8a9e78c81bed59b47f260723f56bb7e6 Thanks, -- Paul Pluzhnikov 2013-12-18 Andrew Hunter <ahh@google.com> * sysdeps/generic/ldsodefs.h (__signal_safe_memalign): New prototype. (__signal_safe_malloc, __signal_safe_free): Likewise. (__signal_safe_realloc, __signal_safe_calloc): Likewise. * elf/dl-misc.c (__signal_safe_allocator_header): New struct. (__signal_safe_memalign, __signal_safe_malloc): New function. (__signal_safe_free, __signal_safe_realloc): Likewise. (__signal_safe_calloc): Likewise. * elf/dl-tls.c (allocate_dtv, _dl_clear_dtv): Call signal-safe functions. (_dl_deallocate_tls, _dl_update_slotinfo): Likewise.
Attachment:
ahh-glibc-20131210.2a.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |