This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] Add a signal-safe malloc replacement
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Andrew Hunter <ahh at google dot com>
- Cc: OndÅej BÃlka <neleai at seznam dot cz>, GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Wed, 18 Dec 2013 16:12:34 -0800
- Subject: Re: [PATCH 2/4] Add a signal-safe malloc replacement
- Authentication-results: sourceware.org; auth=none
- References: <1386273671-13010-1-git-send-email-ahh at google dot com> <1386722143-10513-1-git-send-email-ahh at google dot com> <1386722143-10513-2-git-send-email-ahh at google dot com> <20131211100309 dot GA24512 at domone dot podge> <CALoOobMKYyD7G7fbYHq2aqx32S_QMs19DZY2YhJ-JA4_d4717A at mail dot gmail dot com> <CADroS=7LJ4uKGB30jsNn2xV5Dxr7eZ24H3NScHUCYWORUnMTfQ at mail dot gmail dot com>
On Wed, Dec 18, 2013 at 4:06 PM, Andrew Hunter <ahh@google.com> wrote:
> I think the proper fix is to reorder the patches -- move Factor out
> _dl_clear_dtv before this one (having it just call free, not
> signal_safe_). Then apply this patch and replace the free with
> signal_safe_free here.)
Aha. I haven't looked at patch 3 (until now).
I agree, applying slightly modified patch 3, then patch 2, is the way to go.
I'll test and commit in that order.
--
Paul Pluzhnikov