This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove __FAVOR_BSD
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 17 Dec 2013 09:53:18 -0800 (PST)
- Subject: Re: Remove __FAVOR_BSD
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1312052315530 dot 16480 at digraph dot polyomino dot org dot uk> <20131216225338 dot 6FA7E7442E at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1312171726260 dot 14559 at digraph dot polyomino dot org dot uk>
> There are deliberately no NEWS changes in this patch, on the basis
> that the correct NEWS entries for such cleanups can be worked out
> later once we see which cleanups get in 2.19.
I'd be happier with an obvious placeholder entry in NEWS that makes it
clear we need to go back and edit it before release.
> @comment unistd.h
> @comment POSIX.1
> -@deftypefn {POSIX.1 Function} pid_t getpgrp (void)
> -The POSIX.1 definition of @code{getpgrp} returns the process group ID of
> +@deftypefn pid_t getpgrp (void)
@deftypefn needs the "category" argument.
To drop it, make it @deftypefun.
> -@comment unistd.h
> @comment SVID
> @deftypefn {System V Function} int getpgid (pid_t @var{pid})
This should now be:
@comment POSIX.1
@deftypefun int getpgid (pid_t @var{pid})
> New programs should always use `setpgid' instead.
>
> - The default in GNU is to provide the System V function. The BSD
> - function is available under -D_BSD_SOURCE. */
> -
> -# ifndef __FAVOR_BSD
> + GNU provides the System V function. */
We should refer to it as the POSIX.1 interface, not the SysV interface.
Otherwise looks OK to me.
Thanks,
Roland