This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Drop PER_THREAD conditionals.
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 9 Dec 2013 10:54:23 +0530
- Subject: Re: [PATCH] Drop PER_THREAD conditionals.
- Authentication-results: sourceware.org; auth=none
- References: <20131206000402 dot GA17751 at domone dot podge> <20131206034209 dot GD14845 at spoyarek dot pnq dot redhat dot com> <20131208001534 dot GA4336 at domone dot podge>
On Sun, Dec 08, 2013 at 01:15:34AM +0100, OndÅej BÃlka wrote:
> > I don't think the ChangeLog is correct, but the patch itself looks OK.
> >
> So how should changelog look like?
I'd go for something like this:
* malloc/Makefile (CPPFLAGS-malloc.c): Remove -DPER_THREAD
flag.
* malloc/arena.c: Remove PER_THREAD conditional.
[!PER_THREAD]: Remove code.
(ptmalloc_unlock_all2): Likewise.
(ptmalloc_init): Likewise.
(_int_new_arena): Likewise.
(arena_get2): Likewise.
* malloc/hooks.c (__malloc_get_state): Likewise.
(__malloc_set_state): Likewise.
* malloc/malloc.c: Likewise.
(struct malloc_state): Likewise.
(struct malloc_par): Likewise.
(__libc_realloc): Likewise.
(__libc_mallopt): Likewise.
Also, I just noticed that you need to remove the
'memory_arena_reuse_realloc' systemtap probe documentation from
probes.texi.
Siddhesh