This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Drop PER_THREAD conditionals.


On Sun, Dec 08, 2013 at 01:15:34AM +0100, OndÅej BÃlka wrote:
> > I don't think the ChangeLog is correct, but the patch itself looks OK.
> > 
> So how should changelog look like?

I'd go for something like this:

	* malloc/Makefile (CPPFLAGS-malloc.c): Remove -DPER_THREAD
	flag.
	* malloc/arena.c: Remove PER_THREAD conditional.
	[!PER_THREAD]: Remove code.
	(ptmalloc_unlock_all2): Likewise.
	(ptmalloc_init): Likewise.
	(_int_new_arena): Likewise.
	(arena_get2): Likewise.
	* malloc/hooks.c (__malloc_get_state): Likewise.
	(__malloc_set_state): Likewise.
	* malloc/malloc.c: Likewise.
	(struct malloc_state): Likewise.
	(struct malloc_par): Likewise.
	(__libc_realloc): Likewise.
	(__libc_mallopt): Likewise.

Also, I just noticed that you need to remove the
'memory_arena_reuse_realloc' systemtap probe documentation from
probes.texi.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]