This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2.1] Use saturated arithmetic for overflow detection.

On 12/03/2013 03:16 AM, OndÅej BÃlka wrote:

> +mul_s (size_t x, size_t y)

The implementation here is slow and complex.  It'd be better to use
the underlying hardware arithmetic, which typically supports
double-length products.  On the rare hardware that doesn't support
that, let's keep it simple.  Something like this, perhaps?  You'll
need to arrange for HAVE___INT128 to be configured properly; it should
be 1 on typical 64-bit platforms.

/* An unsigned integer type that is at least twice the width of size_t.  */
#if SIZE_MAX >> 31 <= 1
# define double_size_t unsigned long long
#elif SIZE_MAX >> 31 >> 31 >> 1 <= 1 && HAVE___INT128
# define double_size_t unsigned __int128

static inline __attribute__((always_inline, unused)) size_t
mul_s (size_t x, size_t y)
#ifdef double_size_t
  double_size_t y1 = y;
  double_size_t product = x * y1;
  if (__glibc_unlikely (SIZE_MAX < product))
    return SIZE_MAX;
  return product;
  if (__builtin_constant_p (x))
    return mul_s (y, x);
  if (__glibc_unlikely (x > SIZE_MAX / y))
    return SIZE_MAX;
  return x * y;

> +static inline __attribute__((always_inline, unused)) size_t
> +add_s (size_t x, size_t y)
> +{
> +  /* This check is recognized by gcc  */
> +  if (__glibc_unlikely (x + y < x))

There's no need for that comment.  On the other hand, with my pedantic
hat on, you might want to mention that the above test assumes that
INT_MAX < SIZE_MAX.  Perhaps put in a static assertion (doesn't
glibc support _Static_assert yet? if not, just add a comment).

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]