This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove duplicate ifunc benchtests.


On Tue, Nov 12, 2013 at 11:16:25AM +0100, OndÅej BÃlka wrote:
> Hi,
> 
> Current benchmarks print same data twice, when ifunc is not defined it
> covers only some implementations and when it is defined then all
> implementations are tested (results of ifunc/nonifunc may differ a lot
> but that is a separate bug report.)
> 
> This can be solved by dropping a ifunc files and defining TEST_IFUNC
> unconditionally.
> 
> OK to commit?

Looks OK to me.

> diff --git a/benchtests/bench-string.h b/benchtests/bench-string.h
> index 53e796a..46b4138 100644
> --- a/benchtests/bench-string.h
> +++ b/benchtests/bench-string.h
> @@ -17,6 +17,7 @@
>     <http://www.gnu.org/licenses/>.  */
>  
>  #include <sys/cdefs.h>
> +#define TEST_IFUNC 1
>  
>  typedef struct
>  {

Please post an additional patch to just remove TEST_IFUNC altogether,
assuming it to be 1.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]