This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ping: [patchv2] Fix vDSO l_name for GDB's: Can't read pathname for load map: Input/output error.


On 11/07/2013 05:07 PM, Carlos O'Donell wrote:
> I suggest the following more verbose comment:
> 
> /* When we create the executable link map, or a VDSO link map, we start
>    with "" for the l_name. In these cases "" points to ld.so rodata
>    and won't get dumped during core file generation. Therefore to assist
>    gdb and to create more self-contained core files we adjust l_name to
>    point at the newly allocated copy (which will get dumped) instead of 
>    the ld.so rodata copy.  */
> 
> OK with those changes, and confirmation that no regressions were seen in the
> glibc testsuite.

Please also add `[BZ #387]' to your ChangeLog, and close out bug 387 as
fixed.

If you don't have commit please tell me.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]