This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: About tls comment.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Rich Felker <dalias at aerifal dot cx>, Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Sat, 02 Nov 2013 12:45:51 -0400
- Subject: Re: About tls comment.
- Authentication-results: sourceware.org; auth=none
- References: <20131101164400 dot GA4917 at domone dot podge> <87sivgyopi dot fsf at igel dot home> <20131101221614 dot GK20515 at brightrain dot aerifal dot cx> <87mwln5mii dot fsf at igel dot home> <20131102145827 dot GA10582 at domone dot podge>
On 11/02/2013 10:58 AM, OndÅej BÃlka wrote:
> On Sat, Nov 02, 2013 at 07:46:29AM +0100, Andreas Schwab wrote:
>> Rich Felker <dalias@aerifal.cx> writes:
>>
>>> On Fri, Nov 01, 2013 at 07:14:01PM +0100, Andreas Schwab wrote:
>>>> OndÅej BÃlka <neleai@seznam.cz> writes:
>>>>
>>>>> It dates back to 2002. This comment puzzles me, as we do tls
>>>>> initialization just below or did I missed something?
>>>>
>>>> See <http://repo.or.cz/w/glibc/history.git/commitdiff/19485a5>.
>>>
>>> It's not immediately apparent to me how this answers the question. If
>>> you know more and it's not too big a time-waster, could you comment a
>>> bit more on it?
>>
>> You have to ask Uli on it.
>>
> From diff this looks like obsolete comment after code changed.
>
> More specifically what is wrong with patch below?
I don't know, but the undocumented interdependencies for TLS
are large and complicated. It would take me quite a bit of
review to figure it out.
I also won't accept any TLS patches without a detailed description
from the patch author about exactly what was wrong with the
original code and why the code should be changed in the way
that it is changed.
> It should fix a bug
> https://sourceware.org/bugzilla/show_bug.cgi?id=15199
> as LD_PRELOAD is handled before tls is initialized.
>
> However it triggers following bug which causes tests that use tls fail.
> https://sourceware.org/bugzilla/show_bug.cgi?id=13823
>
> A second question is that I found macro NONTLS_INIT_TP which is never
> defined or used. OK to remove that?
Yes.
> -#ifndef NONTLS_INIT_TP
> -# define NONTLS_INIT_TP do { } while (0)
> -#endif
This is the only part of the patch that I have reviewed and approve.
The macro is unused and can be removed.
Post a COMMITTED patch with the final changes.
Cheers,
Carlos.