This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't use gethostbyaddr to determine canonical name


On Wed, Oct 16, 2013 at 01:00:16PM +0200, Andreas Schwab wrote:
> As explained in the PR, it is wrong to try to determine the canonical
> name from the IP address.  The sole purpose of AI_CANONNAME is to look
> at a CNAME record if it exists, and using the name argument unchanged if
> not.
> 
> Andreas.
> 
> 	[BZ#15218]
> 	* sysdeps/posix/getaddrinfo.c (gaih_inet): Don't use gethostbyaddr
> 	to determine canonical name.

Looks good to me too.  This patch has been in Fedora for a while
now[1], so it is also well tested.

Siddhesh

[1] http://pkgs.fedoraproject.org/cgit/glibc.git/tree/glibc-fedora-gai-canonical.patch

Of course, you would know that since you had committed it :)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]