This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2.0][BZ #15670] Replace alloca in __tzfile_read by malloc.


On Wednesday 16 October 2013 12:40:40 OndÅej BÃlka wrote:
> @@ -173,6 +164,7 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) {
>        /* Nothing to do.  */
>        __use_tzfile = 1;
> +      free (new);
>        return;
>      }

i wonder if this would benefit from a "goto done" and then adding "done:" at 
the end ...

> @@ -528,11 +520,13 @@ __tzfile_read (const char *file, size_t extra, char
> **extrap) __timezone = -rule_stdoff;
> 
>    __use_tzfile = 1;
> +  free (new);
>    return;

this would get a new "done:" label

either way, LGTM
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]