This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #14029] Acknowledge that fnmatch can fail.


On 13/10/13 16:22, OndÅej BÃlka wrote:
> Hi,
> 
> This corrects factual error in manual as fnmatch can fail when there is
> not enough memory or when pattern contains illegal sequence.
> 
> OK to commit this?
> 
> 	* manual/pattern.texi: Acknowledge that fnmatch can fail.
> 
> diff --git a/manual/pattern.texi b/manual/pattern.texi
> index 1966f3f..55f6682 100644
> --- a/manual/pattern.texi
> +++ b/manual/pattern.texi
> @@ -36,10 +36,8 @@ returns the nonzero value @code{FNM_NOMATCH}.  The arguments
>  The argument @var{flags} is a combination of flag bits that alter the
>  details of matching.  See below for a list of the defined flags.
>  
> -In @theglibc{}, @code{fnmatch} cannot experience an ``error''---it
> -always returns an answer for whether the match succeeds.  However, other
> -implementations of @code{fnmatch} might sometimes report ``errors''.
> -They would do so by returning nonzero values that are not equal to
> +The @code{fnmatch} might sometimes report ``errors''.
> +It do so by returning nonzero values that are not equal to
>  @code{FNM_NOMATCH}.
>  @end deftypefun

That needs gramatical corrections.  I suggest:

In @theglibc{}, @code{fnmatch} might sometimes report ``errors'' by
returning nonzero values that are not equal to @code{FNM_NOMATCH}.

Allan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]